Merged
Conversation
# Conflicts: # Sources/OversizeKit/SettingsKit/Views/Security/SecuritySettingsView.swift
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors navigation to use NavigatorUI/OversizeNavigation, updates UI layouts to NavigationLayoutView, and centralizes routing via SettingsDestinations. It also modernizes async review and launch flows, replaces legacy Router usage, and cleans up logging.
- Migrate from custom
RoutertonavigatorandSettingsDestinationsacross Settings and Store modules - Update various Views to
NavigationLayoutView, adjust toolbars, and safe‐area insets - Add async handling to review and launcher flows, inject subscription names, and reorganize dependencies
Reviewed Changes
Copilot reviewed 44 out of 45 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Sources/OversizeNoticeKit/NoticeListViewModel.swift | Simplify review banner flag and remove old computed property |
| Sources/OversizeNoticeKit/NoticeListView.swift | Wrap reviewService calls in Task with await |
| Sources/OversizeKit/SystemKit/SystemServices.swift | Change accentColor → tint and update injected review service |
| Sources/OversizeKit/StoreKit/Views/SubscriptionPrivacyView.swift | Add subscriptionsName parameter and replace static Info lookup |
| Sources/OversizeKit/StoreKit/Views/PrmiumBannerRow.swift | Refactor navigation to navigator, remove default badge fallback |
| Sources/OversizeKit/StoreKit/ViewModifier/OnPremiumTap.swift | Replace sheet presentation with navigator.navigate |
| Sources/OversizeKit/StoreKit/StoreScreen/ViewModel/StoreViewModel.swift | Replace generic log with logError/logInfo/logSuccess |
| Sources/OversizeKit/StoreKit/StoreScreen/StoreView.swift | Switch to NavigationLayoutView, configure toolbar/title mode |
| Sources/OversizeKit/SettingsKit/Views/* | Convert Page/PageView to NavigationLayoutView, inject navigator |
| Sources/OversizeKit/SettingsKit/SettingsRouter/SettingsDestinations.swift | Introduce SettingsDestinations enum for navigation targets |
| Sources/OversizeKit/LauncherKit/LauncherViewModel.swift | Add async onboarding/app‐update callbacks and enhance logging |
| Sources/OversizeKit/LauncherKit/Launcher.swift | Refactor launch flow to .task(viewModel.onAppear) and scene handling |
| Package.swift | Extract commonDependencies, reorganize package lists |
| AppExample/Example/* | Update import Factory → import FactoryKit in example targets |
Comments suppressed due to low confidence (2)
Sources/OversizeKit/SettingsKit/SettingsRouter/SettingsDestinations.swift:18
- The
ourResorsescase is misspelled. Rename it toourResourcesfor correct spelling and clarity.
case ourResorses
Sources/OversizeKit/LauncherKit/LauncherViewModel.swift:188
- The method name
onCompeteOnboardingis misleading; it appears to be a typo foronCompleteOnboarding. Consider renaming for accuracy.
func onCompeteOnboarding(_ isCompletedOnbarding: Bool) {
| ) | ||
|
|
||
| Text(Info.store.subscriptionsName) | ||
| Text(viewModel.productsState.result?.banner.badge ?? "") |
There was a problem hiding this comment.
Using an empty string fallback will result in a blank badge when banner.badge is nil. Consider providing a meaningful default (e.g., "Pro") or ensuring banner.badge is non-optional.
Suggested change
| Text(viewModel.productsState.result?.banner.badge ?? "") | |
| Text(viewModel.productsState.result?.banner.badge ?? "Pro") |
Co-authored-by: Copilot <[email protected]>
* Initial plan * Complete README.md rewrite with comprehensive documentation Co-authored-by: aromanov91 <[email protected]> * Update README.md --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aromanov91 <[email protected]> Co-authored-by: Alexander Romanov <[email protected]>
* Initial plan * Fix simple typos: Badge, pinCodeEnabled, lockscreen, appearance, etc. Co-authored-by: aromanov91 <[email protected]> * Rename files and fix remaining typos: PremiumBannerRow, StoreInstructionsView, Appearance folder Co-authored-by: aromanov91 <[email protected]> * Fix typo: Resorses → Resources (file name, struct name, enum case) Co-authored-by: aromanov91 <[email protected]> * Fix --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: aromanov91 <[email protected]> Co-authored-by: Alexander Romanov <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.