Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d8bb3e824f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| @MainActor | ||
| static func buildCached( | ||
| cacheKey: String = String(describing: Self.self), |
There was a problem hiding this comment.
The new buildCached API uses String(describing: Self.self) as its default cache key, so every invocation of the same module type shares one ViewState regardless of input. In modules where state is initialized from input (for example ProductDetailViewState.init(input:) sets the product ID), opening the module for a different entity will silently reuse stale state and ignore the new input because getOrCreate never runs the factory again once the key is populated.
Useful? React with 👍 / 👎.
1 participant
No description provided.