Add macros by aromanov91 · Pull Request #2 · oversizedev/OversizeArchitecture

aromanov91 · 2025-09-24T21:17:13Z

No description provided.

Copilot

Pull Request Overview

This PR introduces a comprehensive feature implementation for "screens" that adds architectural components for modular Swift UI development. The implementation includes macro-based code generation for ViewModels, Views, and Modules, along with protocol definitions and test components.

Adds macro system for automated code generation (@viewmodel, @view, @module)
Implements architectural protocols for ViewState, ViewModel, View, and Module components
Creates extensive test suite with product-based example modules

Reviewed Changes

Copilot reviewed 36 out of 36 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
Sources/OversizeArchitecture/Macros.swift	Defines public macro interfaces for ViewModel, View, and Module generation
Sources/OversizeArchitectureMacros/Macros/*.swift	Implements macro expansion logic for automated code generation
Sources/OversizeArchitecture/Protocols/*.swift	Defines core architectural protocols with associated types
Tests/OversizeArchitectureTests/ArchitectureTests/TestViews/	Comprehensive test modules demonstrating the architecture
Tests/OversizeArchitectureTests/ArchitectureTests/*SwiftTests.swift	Extensive test suite using Swift Testing framework
README.md	Documentation explaining the architecture and macro usage

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-24T21:18:08Z

Tests/OversizeArchitectureTests/ArchitectureTests/ViewStateTests.swift

+
+        await MainActor.run {
+            #expect(state.id == product.id)
+            #expect(state.name == "Product")


Test expects state.name to be 'Product' but the test creates a product with name 'Test Product'. The expected value should match the input product name or the test should verify the actual behavior of ProductDetailViewState initialization.

Suggested change

#expect(state.name == "Product")

#expect(state.name == product.name)

Copilot · 2025-09-24T21:18:09Z

Tests/OversizeArchitectureTests/ArchitectureTests/ViewStateTests.swift

+        }
+
+        await MainActor.run {
+            #expect(state.name == "Product")


Similar issue as above - test expects 'Product' as name when input is nil, but this should verify the actual default behavior of ProductDetailViewState.

Suggested change

#expect(state.name == "Product")

let defaultState = ProductDetailViewState(input: nil)

#expect(state.name == defaultState.name)

Copilot · 2025-09-24T21:18:09Z

Tests/OversizeArchitectureTests/ArchitectureTests/TestViews/Detail/ProductDetailViewState.swift

@@ -0,0 +1,17 @@
+//
+// Copyright © 2025 Alexander Romanov
+// MealProductDetailViewState.swift, created on 10.07.2025


Comment header refers to 'MealProductDetailViewState.swift' but the actual file is 'ProductDetailViewState.swift'. The comment should match the actual filename.

Suggested change

// MealProductDetailViewState.swift, created on 10.07.2025

// ProductDetailViewState.swift, created on 10.07.2025

Copilot · 2025-09-24T21:18:09Z

Tests/OversizeArchitectureTests/ArchitectureTests/TestViews/Detail/ProductDetailViewModel.swift

@@ -0,0 +1,32 @@
+//
+// Copyright © 2025 Alexander Romanov
+// MealProductDetailViewModel.swift, created on 10.07.2025


Comment header refers to 'MealProductDetailViewModel.swift' but the actual file is 'ProductDetailViewModel.swift'. The comment should match the actual filename.

Suggested change

// MealProductDetailViewModel.swift, created on 10.07.2025

// ProductDetailViewModel.swift, created on 10.07.2025

Copilot · 2025-09-24T21:18:10Z

Tests/OversizeArchitectureTests/ArchitectureTests/TestViews/Detail/ProductDetailView.swift

@@ -0,0 +1,19 @@
+//
+// Copyright © 2025 Alexander Romanov
+// MealProductDetailScreen.swift, created on 10.07.2025


Comment header refers to 'MealProductDetailScreen.swift' but the actual file is 'ProductDetailView.swift'. The comment should match the actual filename.

Suggested change

// MealProductDetailScreen.swift, created on 10.07.2025

// ProductDetailView.swift, created on 10.07.2025

Copilot · 2025-09-24T21:18:10Z

Tests/OversizeArchitectureTests/ArchitectureTests/TestViews/List/ProductList.swift

@@ -0,0 +1,35 @@
+//
+// Copyright © 2025 Alexander Romanov
+// ProductListInput.swift, created on 17.09.2025


Comment header refers to 'ProductListInput.swift' but the actual file is 'ProductListModule.swift'. The comment should match the actual filename.

Suggested change

// ProductListInput.swift, created on 17.09.2025

// ProductListModule.swift, created on 17.09.2025

Copilot · 2025-09-24T21:18:10Z

Tests/OversizeArchitectureTests/ArchitectureTests/TestViews/Edit/ProductEdit.swift

@@ -0,0 +1,50 @@
+//
+// Copyright © 2025 Alexander Romanov
+// ProductEditInput.swift, created on 17.09.2025


Comment header refers to 'ProductEditInput.swift' but the actual file is 'ProductEditModule.swift'. The comment should match the actual filename.

Suggested change

// ProductEditInput.swift, created on 17.09.2025

// ProductEditModule.swift, created on 17.09.2025

Copilot

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Tests/OversizeArchitectureTests/ArchitectureMacrosTests/ViewModelMacroSwiftTests.swift

…delMacroSwiftTests.swift Co-authored-by: Copilot <[email protected]>

Copilot

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-25T10:29:14Z

Tests/OversizeArchitectureTests/ArchitectureMacrosTests/ViewModelMacroSwiftTests.swift

 //
 // Copyright © 2025 Alexander Romanov
-// ViewModelMacroTests.swift, created on 12.09.2025
+// ViewModelMacroSwiftTests.swift, created on 18.09.2024


The creation date shows 2024 but should be 2025 based on the copyright year and other file dates in this PR.

Suggested change

// ViewModelMacroSwiftTests.swift, created on 18.09.2024

// ViewModelMacroSwiftTests.swift, created on 18.09.2025

Copilot

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated 1 comment.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-09-25T10:35:25Z

Tests/OversizeArchitectureTests/ArchitectureMacrosTests/ViewModelMacroTests.swift

 //
 // Copyright © 2025 Alexander Romanov
-// ViewModelMacroTests.swift, created on 12.09.2025
+// ViewModelMacroTests.swift, created on 18.09.2024


The creation date shows 2024 but should be 2025 to match other files in the codebase.

Suggested change

// ViewModelMacroTests.swift, created on 18.09.2024

// ViewModelMacroTests.swift, created on 18.09.2025

Copilot

Pull Request Overview

Copilot reviewed 36 out of 36 changed files in this pull request and generated no new comments.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

aromanov91 added 12 commits September 17, 2025 00:24

Add Screen macros

1d7dd06

Add test screens

e968bc6

Upd

e4dee45

Upd

b973ad1

Add product init

3103b19

Refactor

0e90b9a

Migrate to Swift Testing

a5263d2

Update tests

ac5fd93

Add init in ViewModel Macro

9fca103

Add View macro

95a4e67

Add Module macro

fdf8bba

Update examples

9c8f1ff

Copilot AI review requested due to automatic review settings September 24, 2025 21:17

Copilot AI reviewed Sep 24, 2025

View reviewed changes

aromanov91 changed the title ~~Feature/screens~~ Add macros Sep 25, 2025

Update @module macro

c266fa3

aromanov91 requested a review from Copilot September 25, 2025 10:25

Copilot AI reviewed Sep 25, 2025

View reviewed changes

Tests/OversizeArchitectureTests/ArchitectureMacrosTests/ViewModelMacroSwiftTests.swift Outdated Show resolved Hide resolved

Update Tests/OversizeArchitectureTests/ArchitectureMacrosTests/ViewMo…

727450f

…delMacroSwiftTests.swift Co-authored-by: Copilot <[email protected]>

Copilot AI review requested due to automatic review settings September 25, 2025 10:28

Copilot AI reviewed Sep 25, 2025

View reviewed changes

Rename tests

7c4342a

aromanov91 requested a review from Copilot September 25, 2025 10:34

Fix

35a3174

Copilot AI reviewed Sep 25, 2025

View reviewed changes

aromanov91 requested a review from Copilot September 25, 2025 10:35

Copilot AI reviewed Sep 25, 2025

View reviewed changes

aromanov91 merged commit e193648 into main Sep 26, 2025
4 checks passed

aromanov91 deleted the feature/screens branch September 26, 2025 19:20

	#expect(state.name == "Product")
	#expect(state.name == product.name)

	#expect(state.name == "Product")
	let defaultState = ProductDetailViewState(input: nil)
	#expect(state.name == defaultState.name)

	// MealProductDetailViewState.swift, created on 10.07.2025
	// ProductDetailViewState.swift, created on 10.07.2025

	// MealProductDetailViewModel.swift, created on 10.07.2025
	// ProductDetailViewModel.swift, created on 10.07.2025

	// MealProductDetailScreen.swift, created on 10.07.2025
	// ProductDetailView.swift, created on 10.07.2025

	// ProductListInput.swift, created on 17.09.2025
	// ProductListModule.swift, created on 17.09.2025

	// ProductEditInput.swift, created on 17.09.2025
	// ProductEditModule.swift, created on 17.09.2025

	// ViewModelMacroSwiftTests.swift, created on 18.09.2024
	// ViewModelMacroSwiftTests.swift, created on 18.09.2025

	// ViewModelMacroTests.swift, created on 18.09.2024
	// ViewModelMacroTests.swift, created on 18.09.2025

Conversation

aromanov91 commented Sep 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Sep 25, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants