Skip to content

Add Protocols#1

Merged
aromanov91 merged 5 commits intomainfrom
feature/architecture
Sep 13, 2025
Merged

Add Protocols#1
aromanov91 merged 5 commits intomainfrom
feature/architecture

Conversation

@aromanov91
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings September 13, 2025 21:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a foundational architecture framework for SwiftUI applications using the Unidirectional Data Flow (UDF) pattern. The framework defines protocols and a reducer class to establish a clear separation between view state, view models, and views with async-safe communication patterns.

  • Adds protocol definitions for view state, view models, and views with associated types and async boundaries
  • Implements a Reducer class to handle action dispatching with async task execution
  • Establishes MainActor boundaries for UI-related operations and Sendable conformance for thread safety

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
Sources/OversizeArchitecture/ViewStateProtocol.swift Defines the base protocol for view state with async update capabilities
Sources/OversizeArchitecture/ViewProtocol.swift Establishes the view protocol with associated types for state and view model
Sources/OversizeArchitecture/ViewModelProtocol.swift Defines the view model protocol with action handling and state initialization
Sources/OversizeArchitecture/Reducer.swift Implements the reducer class for action dispatching with logging

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Sources/OversizeArchitecture/ViewStateProtocol.swift
Comment thread Sources/OversizeArchitecture/Reducer.swift
Copilot AI review requested due to automatic review settings September 13, 2025 21:42
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread Sources/OversizeArchitecture/Protocols/ViewStateProtocol.swift
Comment thread Sources/OversizeArchitecture/Protocols/ViewStateProtocol.swift Outdated
Copilot AI review requested due to automatic review settings September 13, 2025 21:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 7 out of 10 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@aromanov91 aromanov91 merged commit 1137775 into main Sep 13, 2025
4 checks passed
@aromanov91 aromanov91 deleted the feature/architecture branch September 13, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants