fix: hide navigation menu and scorm content width#107
Merged
ahmed-arb merged 1 commit intoOct 24, 2025
Merged
Conversation
mlabeeb03
reviewed
Oct 23, 2025
| </div> | ||
| <iframe class="scorm-embedded" src="{{ index_page_url }}" width="{{ width }}" height="{{ height }}"></iframe> | ||
| {% endif %} | ||
| <iframe class="scorm-embedded {% if not scorm_xblock.navigation_menu_width %}navigation-disabled{% endif %}" src="{{ index_page_url }}" width="{{ width }}" height="{{ height }}"></iframe> |
There was a problem hiding this comment.
This will add the navigation-disabled class if the navigation_menu_width is not set, even if the menu itself is enabled. Can you verify?
Author
There was a problem hiding this comment.
This condition was added due to the statement default will be 30% as shown in below pic which means navigation_menu_width will have a value.
But let's improve the condition and rely on {% if not enable_navigation_menu %}
- Don't show navigation menu and change scorm content width from 70% to 100% when navigation menu is disabled in new pop-up window.
Faraz32123
force-pushed
the
fix/do_not_show_navigation_menu_when_its_disabled
branch
from
804b802 to
b8c7dab
Compare
mlabeeb03
approved these changes
Oct 23, 2025
Author
|
@ahmed-arb @mlabeeb03 can you guys please merge this PR as well for me and create a new release for this xblock, Thanks. |
github-project-automation
Bot
moved this from In review
to Done
in Tutor project management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Before.mov
After:
After.mov