Skip to content

fix: set completion_status to completed when lesson_status is passed #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DawoudSheraz merged 4 commits into from
Aug 25, 2025
+3 −0
Merged

fix: set completion_status to completed when lesson_status is passed #104

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0497fea
fix scorm 1-2
so-jd Aug 7, 2025
75f6118
update changelog
so-jd Aug 8, 2025
efd98d1
update changelog
so-jd Aug 8, 2025
d7db562
update change log and logic
so-jd Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20250808_091751_sorlanczyk_fix_scrom1_2_completion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Bugfix] fixed logic bug in SCORM 1.2 completion handling, when `lesson_status` is `passed` or `failed` it will ensure course completion status. (by @so-jd)
Comment thread
so-jd marked this conversation as resolved.
Outdated
1 change: 1 addition & 0 deletions openedxscorm/scormxblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,7 @@ def set_value(self, data):
lesson_status = value
if lesson_status in ["passed", "failed"]:
success_status = lesson_status
completion_status = "completed"
elif lesson_status in ["completed", "incomplete"]:
completion_status = lesson_status
elif name == "cmi.success_status":
Expand Down