Skip to content

fix: set completion_status to completed when lesson_status is passed #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DawoudSheraz merged 4 commits into from
Aug 25, 2025
Merged

fix: set completion_status to completed when lesson_status is passed #104

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0497fea
fix scorm 1-2
so-jd Aug 7, 2025
75f6118
update changelog
so-jd Aug 8, 2025
efd98d1
update changelog
so-jd Aug 8, 2025
d7db562
update change log and logic
so-jd Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions changelog.d/20250808_091751_sorlanczyk_fix_scrom1_2_completion.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@

Copy link
Copy Markdown
Contributor

@Danyal-Faheem Danyal-Faheem Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also edit this file as per the instructions in this file?

Sorry, this one is probably on me as I provided incomplete instructions.

Copy link
Copy Markdown
Contributor Author

@so-jd so-jd Aug 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah that one is on me, i should have noticed, anyway pushed an update

<!--
Create a changelog entry for every new user-facing change. Please respect the following instructions:
- Indicate breaking changes by prepending an explosion 💥 character.
- Prefix your changes with either [Bugfix], [Improvement], [Feature], [Security], [Deprecation].
- You may optionally append "(by @<author>)" at the end of the line, where "<author>" is either one (just one)
of your GitHub username, real name or affiliated organization. These affiliations will be displayed in
the release notes for every release.
-->

<!-- - 💥[Feature] Foobarize the blorginator. This breaks plugins by renaming the `FOO_DO` filter to `BAR_DO`. (by @regisb) -->
<!-- - [Improvement] This is a non-breaking change. Life is good. (by @billgates) -->
1 change: 1 addition & 0 deletions openedxscorm/scormxblock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,7 @@ def set_value(self, data):
lesson_status = value
if lesson_status in ["passed", "failed"]:
success_status = lesson_status
completion_status = "completed"
elif lesson_status in ["completed", "incomplete"]:
completion_status = lesson_status
elif name == "cmi.success_status":
Expand Down