Skip to content

Conversation

@murtukov
Copy link
Contributor

@murtukov murtukov commented Nov 2, 2025

Q A
Bug fix? yes
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Documented? no

A PR #1184 changed the validation behavior, effectively making the NotBlank and NotNull constraints not work.

Example:

Person:
    type: input-object
    config:
        fields:
            firstName:
                type: String
                validation:
                    - NotBlank: ~
                    - NotNull: ~
            lastName:
                type: String
                validation:
                    - NotBlank: ~
                    - NotNull: ~
mutation {
    editPerson(
        firstName: "John"
    )
}

This request passes validation, and the lastName field is ignored, even though it is marked NotNull and NotBlank, which is an incorrect behavior.

This PR rolls back changes that introduced this bug.

@murtukov murtukov merged commit f4c9b00 into overblog:master Nov 4, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants