node:dgram compatibility improvements #16446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (nread < 0) { | ||
| return self.emit( | ||
| "error", | ||
| Object.assign(new Error("recvmsg"), { |
There was a problem hiding this comment.
This seems not great but I don't want to block merging on it
| throw new ErrnoException(err, 'setBroadcast'); | ||
| const handle = this[kStateSymbol].handle; | ||
| if (!handle?.socket) { | ||
| throw new Error("setBroadcast EBADF"); |
There was a problem hiding this comment.
We should be using a using errors with codes instead of errors with messages. It sounds like we need a helper for throwing a system error with a syscall name and an errno.
| */ | ||
| const handle = this[kStateSymbol].handle; | ||
| if (!handle?.socket) { | ||
| throw new Error("setMulticastTTL EBADF"); |
| */ | ||
| const handle = this[kStateSymbol].handle; | ||
| if (!handle?.socket) { | ||
| throw new Error("setTTL EBADF"); |
| byteLength += length; | ||
| byteLength += length; | ||
| } else { | ||
| throwTypeError(lexicalGlobalObject, throwScope, "Buffer.concat expects Buffer or Uint8Array"_s); |
There was a problem hiding this comment.
This throwTypeError -- is that throwing the error with the code property that is expected or is it not doing that?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the dgram module to add features and fix bugs. Adds some tests from Node.js.
How did you verify your code works?
Added tests.