-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(node/url): add more node:test
parallel cases
#16404
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 12:57 PM PT - Jan 17th, 2025
❌ @DonIsaac, your commit 681c6fa has 1 failures in
🧪 try this PR locally: bunx bun-pr 16404 |
DonIsaac
changed the title
test(node/url):
[WIP] test(node/url): Jan 15, 2025
test-url-relative
test-url-relative
DonIsaac
changed the title
[WIP] test(node/url):
[WIP] test(node/url): add remaining Jan 15, 2025
test-url-relative
node:test
parallel cases
DonIsaac
force-pushed
the
don/test/node-url
branch
6 times, most recently
from
January 15, 2025 22:02
6e496c6
to
0005ce5
Compare
DonIsaac
changed the title
[WIP] test(node/url): add remaining
[WIP] test(node/url): add more Jan 15, 2025
node:test
parallel casesnode:test
parallel cases
DonIsaac
force-pushed
the
don/test/node-url
branch
4 times, most recently
from
January 16, 2025 01:45
28fa82c
to
905c6fc
Compare
Error code formatting fixes should appear in #16385 Edit: resolved |
DonIsaac
force-pushed
the
don/test/node-url
branch
from
January 16, 2025 02:24
905c6fc
to
dac0e1f
Compare
DonIsaac
requested review from
a team,
zackradisic and
Jarred-Sumner
and removed request for
a team
January 16, 2025 06:08
DonIsaac
changed the title
[WIP] test(node/url): add more
test(node/url): add more Jan 16, 2025
node:test
parallel casesnode:test
parallel cases
DonIsaac
force-pushed
the
don/test/node-url
branch
from
January 16, 2025 19:41
dac0e1f
to
5cf0f44
Compare
DonIsaac
force-pushed
the
don/test/node-url
branch
6 times, most recently
from
January 17, 2025 02:29
2ecef10
to
18a133d
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 17, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jan 17, 2025
DonIsaac
force-pushed
the
don/test/node-url
branch
2 times, most recently
from
January 17, 2025 19:30
0739576
to
f185934
Compare
DonIsaac
force-pushed
the
don/test/node-url
branch
from
January 17, 2025 20:18
f185934
to
681c6fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Ports remaining
node:url
parallel test cases.Checklist
test-url-is-url-internaltests node internals we can safely skipThese ones require PRs into WebKit and are not part of this PR:
How did you verify your code works?
This pr, shockingly, contains new test cases