Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(node/url): add more node:test parallel cases #16404

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 15, 2025

What does this PR do?

Ports remaining node:url parallel test cases.

Checklist

  • test-url-format-invalid-input
  • test-url-parse-invalid-input (note: blocked by inconsistencies with reporting deprecation codes)
  • test-url-parse-query
  • test-url-relative
  • test-url-is-url-internal tests node internals we can safely skip
  • test-url-fileurltopath

These ones require PRs into WebKit and are not part of this PR:

  • test-url-pathtofileurl

How did you verify your code works?

This pr, shockingly, contains new test cases

@robobun
Copy link

robobun commented Jan 15, 2025

Updated 12:57 PM PT - Jan 17th, 2025

@DonIsaac, your commit 681c6fa has 1 failures in #9936:


🧪   try this PR locally:

bunx bun-pr 16404

@DonIsaac DonIsaac changed the title test(node/url): test-url-relative [WIP] test(node/url): test-url-relative Jan 15, 2025
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@DonIsaac DonIsaac changed the title [WIP] test(node/url): test-url-relative [WIP] test(node/url): add remaining node:test parallel cases Jan 15, 2025
@DonIsaac DonIsaac force-pushed the don/test/node-url branch 6 times, most recently from 6e496c6 to 0005ce5 Compare January 15, 2025 22:02
@DonIsaac DonIsaac changed the title [WIP] test(node/url): add remaining node:test parallel cases [WIP] test(node/url): add more node:test parallel cases Jan 15, 2025
@DonIsaac DonIsaac force-pushed the don/test/node-url branch 4 times, most recently from 28fa82c to 905c6fc Compare January 16, 2025 01:45
@DonIsaac
Copy link
Contributor Author

DonIsaac commented Jan 16, 2025

Error code formatting fixes should appear in #16385

Edit: resolved

@DonIsaac DonIsaac marked this pull request as ready for review January 16, 2025 06:08
@DonIsaac DonIsaac requested review from a team, zackradisic and Jarred-Sumner and removed request for a team January 16, 2025 06:08
@DonIsaac DonIsaac changed the title [WIP] test(node/url): add more node:test parallel cases test(node/url): add more node:test parallel cases Jan 16, 2025
src/js/builtins.d.ts Outdated Show resolved Hide resolved
@DonIsaac DonIsaac added this pull request to the merge queue Jan 16, 2025
@DonIsaac DonIsaac removed this pull request from the merge queue due to a manual request Jan 16, 2025
@DonIsaac DonIsaac force-pushed the don/test/node-url branch 6 times, most recently from 2ecef10 to 18a133d Compare January 17, 2025 02:29
@DonIsaac DonIsaac added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@DonIsaac DonIsaac added this pull request to the merge queue Jan 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 17, 2025
@DonIsaac DonIsaac force-pushed the don/test/node-url branch 2 times, most recently from 0739576 to f185934 Compare January 17, 2025 19:30
@DonIsaac DonIsaac added this pull request to the merge queue Jan 17, 2025
Merged via the queue into main with commit b412e36 Jan 17, 2025
70 checks passed
@DonIsaac DonIsaac deleted the don/test/node-url branch January 17, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants