-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip javascriptcore's first parse step for ES Modules #15758
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sample files in folder: c5b80dd5337b6903cc6ff8e4172c55f2
…t `export {a, b}`
…lvedSource initializers
…ix a bug where strings_len was much larger than it should have been causing an unnecessarily large allocation
Jarred-Sumner
added a commit
that referenced
this pull request
Jan 13, 2025
This reverts commit ccc7bde.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #7384. Does not fix that problem, but gets closer to fixing it.
This pr:
COMPILE_ERRORS_ONLY=1 bun run build
for building bun that skips codegen. This shows errors ~50% faster and can often reveal an error that was crashing zig previouslyTODO:
Check:
eqlComptime("*default*")
check somehow (either just remove it and it's fine or add special indexes for those)module_loader.zig
line 2633Performance impact:
Benchmark
Run benchmark: