fix windows next tests in ci #11050
Closed
fix windows next tests in ci #11050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paperclover
reviewed
May 15, 2024
| if (r.debug_logs) |*debug| { | ||
| debug.addNoteFmt("The import \"{s}\" is being treated as an absolute path", .{import_path}); | ||
| debug.addNoteFmt("The import \"{s}\" is being treated as an absolute path", .{abs_import_path}); |
There was a problem hiding this comment.
this should print the user-provided path. though, we dont really show this anywhere. (i could never get the debug messages to work)
| pub fn ensureLongPath(buf: anytype, res: [:0]const u8) [:0]u8 { | ||
| assert(buf.ptr == res.ptr); | ||
| if (bun.Environment.isWindows) { | ||
| const long_path_len = bun.windows.GetLongPathNameA( |
There was a problem hiding this comment.
Let's only do this if the file path contains ~{0-9}
There was a problem hiding this comment.
And we should never use the A version of functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
testing using
GetLongPathNamein our resolverHow did you verify your code works?