-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
928e9e4
commit eadc1b4
Showing
5 changed files
with
201 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
111 changes: 111 additions & 0 deletions
111
test/js/node/test/parallel/test-fs-promises-write-optional-params.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,111 @@ | ||
| 'use strict'; | ||
|
|
||
| const common = require('../common'); | ||
|
|
||
| // This test ensures that filehandle.write accepts "named parameters" object | ||
| // and doesn't interpret objects as strings | ||
|
|
||
| const assert = require('assert'); | ||
| const fsPromises = require('fs').promises; | ||
| const tmpdir = require('../common/tmpdir'); | ||
|
|
||
| tmpdir.refresh(); | ||
|
|
||
| const dest = tmpdir.resolve('tmp.txt'); | ||
| const buffer = Buffer.from('zyx'); | ||
|
|
||
| async function testInvalid(dest, expectedCode, ...params) { | ||
| if (params.length >= 2) { | ||
| params[1] = common.mustNotMutateObjectDeep(params[1]); | ||
| } | ||
| let fh; | ||
| try { | ||
| fh = await fsPromises.open(dest, 'w+'); | ||
| console.log({ expectedCode, params }); | ||
| await assert.rejects( | ||
| fh.write(...params), | ||
| { code: expectedCode }); | ||
| } finally { | ||
| await fh?.close(); | ||
| } | ||
| } | ||
|
|
||
| async function testValid(dest, buffer, options) { | ||
| const length = options?.length; | ||
| const offset = options?.offset; | ||
| let fh, writeResult, writeBufCopy, readResult, readBufCopy; | ||
|
|
||
| try { | ||
| fh = await fsPromises.open(dest, 'w'); | ||
| writeResult = await fh.write(buffer, options); | ||
| writeBufCopy = Uint8Array.prototype.slice.call(writeResult.buffer); | ||
| } finally { | ||
| await fh?.close(); | ||
| } | ||
|
|
||
| try { | ||
| fh = await fsPromises.open(dest, 'r'); | ||
| readResult = await fh.read(buffer, options); | ||
| readBufCopy = Uint8Array.prototype.slice.call(readResult.buffer); | ||
| } finally { | ||
| await fh?.close(); | ||
| } | ||
|
|
||
| assert.ok(writeResult.bytesWritten >= readResult.bytesRead); | ||
| if (length !== undefined && length !== null) { | ||
| assert.strictEqual(writeResult.bytesWritten, length); | ||
| assert.strictEqual(readResult.bytesRead, length); | ||
| } | ||
| if (offset === undefined || offset === 0) { | ||
| assert.deepStrictEqual(writeBufCopy, readBufCopy); | ||
| } | ||
| assert.deepStrictEqual(writeResult.buffer, readResult.buffer); | ||
| } | ||
|
|
||
| (async () => { | ||
| // Test if first argument is not wrongly interpreted as ArrayBufferView|string | ||
| for (const badBuffer of [ | ||
| undefined, null, true, 42, 42n, Symbol('42'), NaN, [], () => {}, | ||
| common.mustNotCall(), | ||
| common.mustNotMutateObjectDeep({}), | ||
| Promise.resolve(new Uint8Array(1)), | ||
| {}, | ||
| { buffer: 'amNotParam' }, | ||
| { string: 'amNotParam' }, | ||
| { buffer: new Uint8Array(1).buffer }, | ||
| new Date(), | ||
| new String('notPrimitive'), | ||
| { toString() { return 'amObject'; } }, | ||
| { [Symbol.toPrimitive]: (hint) => 'amObject' }, | ||
| ]) { | ||
| await testInvalid(dest, 'ERR_INVALID_ARG_TYPE', common.mustNotMutateObjectDeep(badBuffer), {}); | ||
| } | ||
|
|
||
| // First argument (buffer or string) is mandatory | ||
| await testInvalid(dest, 'ERR_INVALID_ARG_TYPE'); | ||
|
|
||
| // Various invalid options | ||
| await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { length: 5 }); | ||
| await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { offset: 5 }); | ||
| await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { length: 1, offset: 3 }); | ||
| await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { length: -1 }); | ||
| await testInvalid(dest, 'ERR_OUT_OF_RANGE', buffer, { offset: -1 }); | ||
| await testInvalid(dest, 'ERR_INVALID_ARG_TYPE', buffer, { offset: false }); | ||
| await testInvalid(dest, 'ERR_INVALID_ARG_TYPE', buffer, { offset: true }); | ||
|
|
||
| // Test compatibility with filehandle.read counterpart | ||
| for (const options of [ | ||
| undefined, | ||
| null, | ||
| {}, | ||
| { length: 1 }, | ||
| { position: 5 }, | ||
| { length: 1, position: 5 }, | ||
| { length: 1, position: -1, offset: 2 }, | ||
| { length: null }, | ||
| { position: null }, | ||
| { offset: 1 }, | ||
| ]) { | ||
| await testValid(dest, buffer, common.mustNotMutateObjectDeep(options)); | ||
| } | ||
| })().then(common.mustCall()); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| 'use strict'; | ||
| require('../common'); | ||
| const common = require('../common'); | ||
| const fixtures = require('../common/fixtures'); | ||
| const assert = require('assert'); | ||
| const fs = require('fs'); | ||
| const filepath = fixtures.path('x.txt'); | ||
| const fd = fs.openSync(filepath, 'r'); | ||
| const fsPromises = fs.promises; | ||
|
|
||
| const buffer = new Uint8Array(); | ||
|
|
||
| assert.throws( | ||
| () => fs.readSync(fd, buffer, 0, 10, 0), | ||
| { | ||
| code: 'ERR_INVALID_ARG_VALUE', | ||
| message: 'The argument \'buffer\' is empty and cannot be written. ' + | ||
| 'Received Uint8Array(0) []' | ||
| } | ||
| ); | ||
|
|
||
| assert.throws( | ||
| () => fs.read(fd, buffer, 0, 1, 0, common.mustNotCall()), | ||
| { | ||
| code: 'ERR_INVALID_ARG_VALUE', | ||
| message: 'The argument \'buffer\' is empty and cannot be written. ' + | ||
| 'Received Uint8Array(0) []' | ||
| } | ||
| ); | ||
|
|
||
| (async () => { | ||
| const filehandle = await fsPromises.open(filepath, 'r'); | ||
| assert.rejects( | ||
| () => filehandle.read(buffer, 0, 1, 0), | ||
| { | ||
| code: 'ERR_INVALID_ARG_VALUE', | ||
| message: 'The argument \'buffer\' is empty and cannot be written. ' + | ||
| 'Received Uint8Array(0) []' | ||
| } | ||
| ).then(common.mustCall()); | ||
| })().then(common.mustCall()); |