fix(us): memory leak when getting root certificate (#16073)

oven-sh · Dec 31, 2024 · ab52058 · ab52058
1 parent e96dded
commit ab52058
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/packages/bun-usockets/src/crypto/root_certs.cpp b/packages/bun-usockets/src/crypto/root_certs.cpp
@@ -35,6 +35,9 @@ us_ssl_ctx_get_X509_without_callback_from(struct us_cert_string_t content) {
     OPENSSL_PUT_ERROR(SSL, ERR_R_PEM_LIB);
     goto end;
   }
+
+  // NOTE: PEM_read_bio_X509 allocates, so input BIO must be freed.
+  BIO_free(in);
   return x;
 end:
   X509_free(x);
@@ -140,4 +143,4 @@ extern "C" X509_STORE *us_get_default_ca_store() {
   }
 
   return store;
-}
+}