Open
Conversation
reef-actor
force-pushed
the
compressed-path-support
branch
from
4d01d55 to
f0655f7
Compare
Author
|
LuBlueLu SL60D I tested this with my install, and it fixed my issues. I can now set it up from the UI when selecting to show paths (I could set it up before without the paths or colours selected). I have not done any additional live testing, but I now see the history of my last path. |
|
Same here, works awesome, thanks |
|
Can this be merged now? |
|
many thanks, it morks perfectly <3 |
wolfcam
approved these changes
Nov 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for compressed path data, such as used by the Lubluelu SL60D.
I haven't tested the changes to confirm they do not break on devices using non compressed data (I don't have one).
The way I handle the originX and originY offsets differs to the panel-demo reference code, but I think any other way would require more changes to the map rendering.