fix(models): parse Hermes Agent config schema in model picker#718
Open
1Beekeeper wants to merge 1 commit into
Open
fix(models): parse Hermes Agent config schema in model picker#7181Beekeeper wants to merge 1 commit into
1Beekeeper wants to merge 1 commit into
Conversation
Hermes Agent uses a different config.yaml schema than Hermes Workspace:
- models.default.{provider,model} instead of model: / model.default:
- providers as an array with name field instead of a map
This caused the model picker to show empty when Hermes Agent was the
backend and no models.json existed. The fix:
1. readClaudeDefaultModel() now falls back to models.default.block
2. readClaudeConfigCatalog() normalizes both array and map providers
3. Integration tests added for both schema variants
Fixes empty model list when Hermes Agent backend is active.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hermes Agent uses a different
config.yamlschema than Hermes Workspace:models.default.{provider,model}instead ofmodel:/model.default:providersas an array withnamefield instead of a mapThis caused the model picker to show empty when Hermes Agent was the backend and no
models.jsonexisted. The agent's/v1/modelsendpoint also requires auth (returning 401), so the fallback path failed too.Fix
readClaudeDefaultModel()now falls back tomodels.default.{provider,model}readClaudeConfigCatalog()normalizes both array and mapprovidersTest Plan
pnpm vitest run src/routes/api/__tests__/-models.test.ts→ 5/5 passpnpm vitest run src/routes/api/-models.test.ts→ 2/2 passFixes empty model list when Hermes Agent backend is active.