fix(sessions): keep <workspace_context> directives out of titles and previews#708
Open
bdtsimon wants to merge 1 commit into
Open
fix(sessions): keep <workspace_context> directives out of titles and previews#708bdtsimon wants to merge 1 commit into
bdtsimon wants to merge 1 commit into
Conversation
…previews Workspace context directives injected into messages leaked into derived session titles and previews, so Recent Sessions / Sessions Intelligence displayed raw "<workspace_context active=... name=... path=...>" text. Sanitize user-visible title/preview candidates on three layers — the /api/sessions gateway summary, normalizeSessions() in the chat utils, and the persisted localStorage title store — dropping values that start with (or reduce to) a workspace_context directive and falling back to a friendly session id. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Workspace context directives injected into messages leaked into derived session titles and previews, so Recent Sessions / Sessions Intelligence displayed raw
<workspace_context active="true" name="..." path="...">text. Frontend sidebar cleanup alone wasn't enough because the dashboard reads/api/sessions.Fix
Sanitize user-visible title/preview candidates on three layers:
/api/sessionsgateway summary (cleanGatewaySessionSummary) — dropsderivedTitle/previewthat start with<workspace_context, falling back to a friendly id;normalizeSessions()in the chat utils;Values that start with (or reduce to) a
workspace_contextdirective are dropped; old polluted sessions fall back to a safeSession <id>instead of leaking the directive.Found and fixed while running a self-hosted deployment.
Reviewed by bdtsimon