fix(chat): clear streaming state when the stream finishes#707
Open
bdtsimon wants to merge 1 commit into
Open
Conversation
On finish the hook left streamingText set to the final text (and kept streamingMessageId), so a completed stream could leak stale streaming state into the next render — e.g. a first/new chat reply appearing as separate "p" + "pong" fragments. Clear streamingMessageId and streamingText on finish; the finalized message is appended separately. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On stream finish the hook left
streamingTextset to the final text and keptstreamingMessageId, so completed-stream state could leak into the next render — e.g. a first/new-chat reply briefly appearing as separatep+pongfragments, or stale streaming state lingering.Fix
Clear
streamingMessageIdandstreamingTextwhen the stream ends; the finalizedChatMessageis appended separately (unchanged). One-line change inuse-streaming-message.ts.Found and fixed while running a self-hosted deployment; a new chat with
reply exactly: pongnow returns a cleanpong.Reviewed by bdtsimon