fix: restrict proposal document attachment to the proposal's own owner - #33
Merged
bbjiggy merged 1 commit intoAug 27, 2026
Merged
Conversation
Resolves ourdao#21 — attach_document only checked that the caller was an active DAO member, so any member could overwrite any other proposal's attached document (loan or treasury). Added proposal_owner() (borrower for loan proposals, proposer for treasury proposals) and require the caller to match before allowing the write. New Error::NotProposalOwner (73). Closes ourdao#20 Closes ourdao#21 Closes ourdao#25 Closes ourdao#24
|
@Gbangbolaoluwagbemiga Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
attach_documentonly checked that the caller was an active DAO member — any member could overwrite any other member's proposal document (loan or treasury). Addedproposal_owner()(borrower for loan proposals, proposer for treasury proposals) and require the caller to match before allowing the write. NewError::NotProposalOwner.Closes #20
Closes #21
Closes #25
Closes #24