fix(idl): avoid quoted string constant values#4580
Open
abhinavgautam01 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3607
Summary
#[constant]values using their actual string contents instead of Rust debug formatting"\"favor\""&strconstant in the IDL fixtureTesting
cargo test -p anchor-syncargo test -p anchor-cli idl_ts_preserves_literal_valuesCARGO_NET_OFFLINE=true target/debug/anchor idl build -o /private/tmp/idl-3607.jsondiff -u tests/idl/idls/idl.json /private/tmp/idl-3607.jsontarget/debug/anchor idl type /private/tmp/idl-3607.json > /private/tmp/idl-3607.tsrg -n 'seedPrefix|favor|\\"favor\\"' /private/tmp/idl-3607.tsgit diff --check