fix(ts): validate instruction args before borsh encode#4560
Open
swaroop-osec wants to merge 2 commits into
Open
fix(ts): validate instruction args before borsh encode#4560swaroop-osec wants to merge 2 commits into
swaroop-osec wants to merge 2 commits into
Conversation
Collaborator
|
@swaroop-osec Please fix the lint issues |
0x4ka5h
approved these changes
May 21, 2026
Collaborator
0x4ka5h
left a comment
0x4ka5h
left a comment
There was a problem hiding this comment.
the pr looks good to me, expect that case which i'm not sure about. @jamie-osec can you have a look at it once.
| } | ||
| const missing = encoder.args | ||
| .map((a) => a.name) | ||
| .filter((name) => !(name in ix)); |
Collaborator
There was a problem hiding this comment.
i'm not sure about using in here. I got this explanation from GPT
inreturns true when the property exists anywhere in the prototype chain, not just as an own property. Every plain{}inherits a fixed set of property names fromObject.prototype
e.g; "toString" in {} -> true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2615