Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide channelname as xesam:artist #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Provide channelname as xesam:artist #18

wants to merge 1 commit into from

Conversation

Robbe7730
Copy link

This uses yt-formatted-string-tags, which opens up the possibility to get more data from the YouTube page. These may however require more maintenance if YouTube changes their layout.

@otommod
Copy link
Owner

otommod commented Feb 3, 2019

Hello, sorry for the delay.

The reason I didn't use the channel name as the artist is that in many cases it's the channel is not actually the content creator/artist. However, I'm not opposed to this PR.

YouTube sometimes also exposes content-id info about songs in a video though this gets less useful in videos with many songs.

@Robbe7730
Copy link
Author

Robbe7730 commented Feb 3, 2019

About the videos with many songs, according to the freedesktop specification, xesam:artist is a list of strings, so we could add all the different artists. If you want to I can look into the content-id titles, and keep the channel as a fallback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants