Repository navigation
feat: add generic links to feed options and items - #165
Merged
Merged
Conversation
links emits extra Atom <link> / RSS 2.0 <atom:link> elements (rel, href, type, hreflang, title, length), absolutized. Relations that already have a field (self, hub, enclosure, replies, paging rels) are rejected by validateInput. Other RSS/Atom versions and JSON Feed ignore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
links: FeedLink[]toFeedOptionsandFeedItem({ rel, href, type?, hreflang?, title?, length? }). Each entry is emitted as an Atom 1.0<link>or an RSS 2.0<atom:link>, withhrefabsolutized.validateInputrequiresrelandhrefand rejects relations that already have their own field (self,hub,enclosure,repliesand the paging rels), so a link is never emitted twice. Older RSS/Atom versions and JSON Feed ignore it. README (en/ja) is updated throughbase/README.base.md.Why?
Atom's link vocabulary (
related,via,license, alternate-language versions withhreflang) could only be reached throughcustomXmlbefore.Related issue(s)
closes
Check
CONTRIBUTING.md(rules)pnpm check(lint & format)pnpm test(functions test)pnpm build(dist/)pnpm test:coverageand check nothing new went uncovered