Repository navigation
feat: add absolutizeContent to resolve relative URLs in item HTML - #162
Merged
Merged
Conversation
Opt-in feed option. Rewrites relative src, href, poster and srcset values inside start tags of item content and description against the base URL, in RSS, Atom and JSON Feed. Text, comments, CDATA and script/style bodies are never touched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in feed option,
absolutizeContent. When set and a base URL is known (baseUrl, whichserveFeeddefaults to the request origin), relativesrc/href/poster/srcsetvalues in each item's HTMLcontentanddescriptionare rewritten to absolute URLs, in RSS, Atom and JSON Feed. The rewrite is a small quote-aware scanner over start tags only: text, comments, CDATA and<script>/<style>bodies are never touched, and absolute values, fragments, other schemes and values with unusual entities are left as written. README (en/ja) is updated throughbase/README.base.md.Why?
baseUrlabsolutizes URL fields but not the HTML insidecontent/description, so images and links from CMS-sourced HTML break in feed readers, which have no page to resolve them against. It is off by default because it changes existing output.Related issue(s)
closes
Check
CONTRIBUTING.md(rules)pnpm check(lint & format)pnpm test(functions test)pnpm build(dist/)pnpm test:coverageand check nothing new went uncovered