Repository navigation
feat: add lint rules and an ignore option to lintInput - #160
Merged
Merged
Conversation
New rules: duplicate ids, future dates, relative URLs in content, enclosure type/length, overlong or HTML titles, and a paging suggestion past 100 items. Every rule has an id, and lintInput accepts { ignore, now }.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add six lint rules to
lintInput(duplicate item ids, future dates, relative URLs incontent/description, enclosuretype/length, overlong or HTML titles, and apagingsuggestion past 100 items). Every rule, including the existing ones, now has an id (LintRuleId), andlintInputtakes an optional third argument{ ignore, now }. The return type is stillstring[], and existing messages are unchanged. README (en/ja) is updated throughbase/README.base.md.Why?
The existing lint output mostly reports missing fields. The mistakes that bite in practice are duplicated ids, timezone mix-ups, relative URLs that feed readers can't resolve, and enclosures with a zero length. Rule ids let a project accept the warnings it doesn't care about instead of dropping the whole check.
Related issue(s)
closes
Check
CONTRIBUTING.md(rules)pnpm check(lint & format)pnpm test(functions test)pnpm build(dist/)pnpm test:coverageand check nothing new went uncovered