This repository was archived by the owner on Jan 15, 2025. It is now read-only.
tar/export: Do checksum → string a bit smarter #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was working on this area of code for a previous PR, and I almost made a refactoring that shared the `hexbuf`. I think the stack allocation here was a premature optimization. Let's just heap allocate - modern allocators are fast with thread-local storage and caches etc. The C side allocates a ton anyways. However there is an optimization we can make here - by passing ownership of the checksum string into the recursive dirtree walk, we can drop it before recursing. Now there's only one heap allocation there instead of it being O(depth).
Member
Author
|
I also did KokaKiwi/rust-hex#66 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on this area of code for a previous PR, and I almost
made a refactoring that shared the
hexbuf. I think the stackallocation here was a premature optimization. Let's just heap
allocate - modern allocators are fast with thread-local
storage and caches etc. The C side allocates a ton anyways.
However there is an optimization we can make here - by passing
ownership of the checksum string into the recursive dirtree walk,
we can drop it before recursing. Now there's only one heap
allocation there instead of it being O(depth).