Skip to content

Implement ICE consent freshness for connectivity detection #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: workflows
Choose a base branch
from

Conversation

murillo128
Copy link

@murillo128 murillo128 commented Jun 10, 2025

WHIP RFC 9725 requires that once a session is set up, consent freshness as per RFC7675 SHALL be used to detect non-graceful disconnection by full ICE implementations and DTLS teardown for session termination by either side.

The patch adds some minimal support for consent freshness, sending ICE requests peridiodically and terminating when we don't receive response to those requests for a number of consecutive requests.

@winlinvip
Copy link
Member

Hi Sergio, thank you for your PR. Could you please provide some background information for this PR in the description? The patch will be generated based on the title and description, and it will be sent via email to the FFmpeg community. Therefore, a detailed description is important for the maintainers to review this PR.

/**
* Consent-freshness constants �����������������������������������������
*/
#define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms � RFC 7675 default */
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms RFC 7675 default */
#define WHIP_CONSENT_DEF_INTERVAL 15000 /* ms - RFC 7675 default */

@murillo128
Copy link
Author

WHIP RFC 9725 requires that once a session is set up, consent freshness as per RFC7675 SHALL be used to detect non-graceful disconnection by full ICE implementations and DTLS teardown for session termination by either side.

The patch adds some minimal support for consent freshness, sending ICE requests peridiodically and terminating when we don't receive response to those requests for a number of consecutive requests.

@murillo128
Copy link
Author

I think all special chars are removed now

@winlinvip winlinvip force-pushed the workflows branch 3 times, most recently from 3294e09 to 4aa17ba Compare June 10, 2025 22:58
@winlinvip winlinvip changed the title Implement ICE consent freshness Implement ICE consent freshness for connectivity detection Jun 27, 2025
@ghost ghost force-pushed the workflows branch from a5e591f to 5a992b3 Compare July 1, 2025 12:45
Signed-off-by: Sergio Garcia Murillo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants