✨ Support custom CII_Best_Practices_URLvia environment variable. #4882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kash2104
requested review from
AdamKorcz and
jeffmendoza
and removed request for
a team
dosubot
bot
added
the
size:M
kash2104
force-pushed
the
issue-4315
branch
2 times, most recently
from
255b563 to
4c0f768
Compare
Signed-off-by: kash2104 <[email protected]>
Signed-off-by: kash2104 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR updates
DefaultCIIBestPracticesClientto support configuring the CII Best Practices base URL via an environment variable.(Is it a bug fix, feature, docs update, something else?)
feature
What is the current behavior?
DefaultCIIBestPracticesClientalways uses the hard-coded URLhttps://www.bestpractices.devwhen querying CII Best Practices badge data.What is the new behavior (if this is a feature change)?**
If the
CII_BEST_PRACTICES_URLenvironment variable is set,DefaultCIIBestPracticesClientwill use it as the base URL.If not set, the client falls back to the existing default URL.
Which issue(s) this PR fixes
Fixes #4315
Special notes for your reviewer
Does this PR introduce a user-facing change?
No
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)