Skip to content

Refactor log parsing in devtool to use encoding/json#422

Closed
osse101 wants to merge 1 commit intodevelopfrom
refactor-log-parsing-9090923883623310275
Closed

Refactor log parsing in devtool to use encoding/json#422
osse101 wants to merge 1 commit intodevelopfrom
refactor-log-parsing-9090923883623310275

Conversation

@osse101
Copy link
Copy Markdown
Owner

@osse101 osse101 commented Apr 6, 2026

This PR replaces the fragile custom string manipulation logic for parsing JSON logs in cmd/devtool/analyze_logs.go with the standard encoding/json package. It unmarshals the JSON lines into a defined logEntry struct to extract values reliably, falling back to existing logic only for non-JSON lines. This significantly improves reliability, especially for JSON logs that might have commas or escaped quotes inside their field values. All project unit tests passed successfully.


PR created automatically by Jules for task 9090923883623310275 started by @osse101

Updated the log parsing logic in `cmd/devtool/analyze_logs.go` to use the standard `encoding/json` package instead of brittle custom string matching for JSON lines. The script now correctly falls back to legacy key=value matching only if a log line does not begin with a '{'.

Co-authored-by: osse101 <[email protected]>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@osse101 osse101 closed this Apr 6, 2026
@osse101 osse101 deleted the refactor-log-parsing-9090923883623310275 branch April 6, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant