Skip to content

chore: refactor analyze-logs to use json unmarshaling#421

Merged
osse101 merged 1 commit intodevelopfrom
refactor-analyze-logs-json-10579855338255011464
Apr 6, 2026
Merged

chore: refactor analyze-logs to use json unmarshaling#421
osse101 merged 1 commit intodevelopfrom
refactor-analyze-logs-json-10579855338255011464

Conversation

@osse101
Copy link
Copy Markdown
Owner

@osse101 osse101 commented Apr 5, 2026

This refactors analyze_logs.go to use encoding/json to unpack JSON log entries, which simplifies the parsing logic and enhances robustness compared to the previous custom string manipulation code, effectively simplifying a devtool log parsing script.


PR created automatically by Jules for task 10579855338255011464 started by @osse101

Update `analyze_logs.go` in `cmd/devtool` to parse JSON-formatted log
lines using `encoding/json` into a struct instead of relying purely
on manual string indexing. This simplifies log extraction logic and
improves parsing robustness while retaining `logfmt` fallback for older logs.

Co-authored-by: osse101 <4764184+osse101@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@osse101 osse101 merged commit 87c49eb into develop Apr 6, 2026
1 check passed
@osse101 osse101 deleted the refactor-analyze-logs-json-10579855338255011464 branch April 6, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant