Add tests for search regions in BrandishBot_Go#419
Conversation
Add unit tests to `internal/search/regions_test.go` to test `LoadSearchRegions`, `resolveRegion`, and `rollRegionItemDrop` functions from `internal/search/regions.go`. This improves test coverage and guarantees behavior regarding level-gated regions, item drop tables, and probabilistic item selection. Co-authored-by: osse101 <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Adds a complete unit test suite for the search region resolution and drop logic in
internal/search/regions.go.TestLoadSearchRegionsto test config file parsing and missing/invalid file handling.TestResolveRegionusing table-driven test cases for logic spanning explorer levels, fallbacks, and weighted hinting.TestRollRegionItemDropusing probabilistic testing to verify accurate drop distribution based on item weights.PR created automatically by Jules for task 17835814880170982923 started by @osse101