fix: prevent scanner token too long crash in features loader#418
fix: prevent scanner token too long crash in features loader#418
Conversation
Set the initial buffer to 64KB and explicitly defined a maximum buffer size of 10MB in internal/features/loader.go to prevent bufio.ErrTooLong crashes when parsing unusually long feature file lines, adhering to the project's standard memory guidelines. Co-authored-by: osse101 <4764184+osse101@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Configured the
bufio.Scannerininternal/features/loader.goto explicitly allow larger buffer sizes up to 10MB. This preventsbufio.ErrTooLongfailures during parsing on files with long lines, aligning with other scanner implementations in the project without regressing the core feature set.PR created automatically by Jules for task 17628341735809234639 started by @osse101