Skip to content

Fix missing timeout in Discord health check#416

Merged
osse101 merged 1 commit intodevelopfrom
refactor-discord-healthcheck-timeout-8953561629141403637
Apr 3, 2026
Merged

Fix missing timeout in Discord health check#416
osse101 merged 1 commit intodevelopfrom
refactor-discord-healthcheck-timeout-8953561629141403637

Conversation

@osse101
Copy link
Copy Markdown
Owner

@osse101 osse101 commented Apr 3, 2026

This PR replaces the usage of the standard library's http.Get in the Discord bot's health check (internal/discord/health.go) with a properly configured http.Client that includes a timeout. The global http.Get does not set a timeout by default, which could lead to the health check endpoint silently hanging if the backend API server is unresponsive. Using h.bot.Client.Client.Get resolves this issue and aligns with the project's codebase patterns for making external HTTP requests.


PR created automatically by Jules for task 8953561629141403637 started by @osse101

Replaced the usage of the global `http.Get` in `internal/discord/health.go` with the pre-configured `http.Client` instance from the bot's API client. This ensures that the HTTP request has an explicit timeout, preventing silent hangs if the API server becomes unresponsive.

Co-authored-by: osse101 <4764184+osse101@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@osse101 osse101 merged commit b9d88ac into develop Apr 3, 2026
1 check passed
@osse101 osse101 deleted the refactor-discord-healthcheck-timeout-8953561629141403637 branch April 3, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant