Skip to content

docs: update documentation for resolved issues #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
osse101 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

docs: update documentation for resolved issues #369

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/issues/missing_discord_registrations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,5 @@ This document tracks features that have backend implementation (Service/Handler
1. Implement `Accept` logic in `internal/duel/service.go` (e.g., coin flip, dice roll).
2. Create `internal/discord/cmd_duel.go` to handle interactions.
3. Register commands in `internal/discord/commands.go`.

- **Status Update (2026-03-21)**: `Accept` method is fully implemented, but discord commands are still not registered.
0 docs/issues/audit_test_quality.md → docs/issues/resolved/audit_test_quality.md
View file
Open in desktop
File renamed without changes.
6 changes: 6 additions & 0 deletions docs/issues/resolved/duel_system.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,3 +260,9 @@ CREATE TABLE duels (

- Confirmed `Accept` method in `internal/duel/service.go` remains unimplemented.
- **Status**: Open

## Status Update (2026-03-21)

**Implementation Status: Complete**

- Confirmed `Accept` method in `internal/duel/service.go` is fully implemented, with coin-flip resolution logic, database transactions, and integration with the user service for item deductions and rewards.
4 changes: 4 additions & 0 deletions docs/issues/placeholder_major_systems.md → ...ues/resolved/placeholder_major_systems.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,3 +46,7 @@ Verified that `internal/duel/service.go` (`Accept`) and `internal/expedition/ser
- **Compost**: Resolved. Verified implementation in `internal/compost/` including service lifecycle, engine logic, and database integration.
- **Expeditions**: Resolved. Verified implementation in `internal/expedition/` including encounter engine, skills, and background worker (`internal/worker/expedition_worker.go`).
- **Duels**: PENDING. `Accept` method still returns "not implemented". This is the last remaining item in this tracking issue.

## Status Update (2026-03-21)

- **Duels**: Resolved. Verified implementation in `internal/duel/` including service lifecycle, engine logic, and database integration.
Loading