Skip to content

Remove chromium + switch to pdfkit#170

Merged
jackcrane merged 5 commits intomainfrom
migrate-chromium-pdfkit
Mar 4, 2026
Merged

Remove chromium + switch to pdfkit#170
jackcrane merged 5 commits intomainfrom
migrate-chromium-pdfkit

Conversation

@jackcrane
Copy link
Collaborator

This pull request refactors invoice PDF generation in the API by removing the dependency on Puppeteer and HTML-based templates, replacing it with direct PDF creation using PDFKit. This streamlines the invoice generation process, reduces system dependencies, and simplifies the codebase. The changes also update Docker configuration and package dependencies accordingly.

Invoice PDF generation refactor:

  • Replaced HTML/EJS template-based invoice generation (invoice.ejs, htmlToPdf.js) and Puppeteer with direct PDF creation using PDFKit in invoice.js. The new implementation builds invoice rows, formats data, and draws the PDF programmatically. [1] [2] [3] [4] [5]
  • Removed the html-pdf-node, ejs, and puppeteer dependencies from api/package.json and added pdfkit. [1] [2]

Dockerfile and environment cleanup:

  • Removed Chromium and related system dependencies from Dockerfile and Dockerfile.e2e, as they are no longer needed for PDF generation. Cleaned up associated environment variables. [1] [2]

Testing cleanup:

  • Removed the obsolete test for HTML-to-PDF conversion, as the functionality no longer exists.

@github-actions
Copy link

github-actions bot commented Mar 4, 2026

E2E Tests: Passed

Video files

admins-can-create-shops.yaml.mp4

@jackcrane jackcrane merged commit 5e46436 into main Mar 4, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant