Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors invoice PDF generation in the API by removing the dependency on Puppeteer and HTML-based templates, replacing it with direct PDF creation using PDFKit. This streamlines the invoice generation process, reduces system dependencies, and simplifies the codebase. The changes also update Docker configuration and package dependencies accordingly.
Invoice PDF generation refactor:
invoice.ejs,htmlToPdf.js) and Puppeteer with direct PDF creation using PDFKit ininvoice.js. The new implementation builds invoice rows, formats data, and draws the PDF programmatically. [1] [2] [3] [4] [5]html-pdf-node,ejs, andpuppeteerdependencies fromapi/package.jsonand addedpdfkit. [1] [2]Dockerfile and environment cleanup:
DockerfileandDockerfile.e2e, as they are no longer needed for PDF generation. Cleaned up associated environment variables. [1] [2]Testing cleanup: