Conversation
|
I created a new user for test cases when db spins up. I had to change around a few set items like in _user.test.js hasPassword to be a boolean, this value was set to false, but since I added another user and this has a field its now true. Im not sure how to set it for that specific user. |
|
Great, ill make sure the flow isn't broken and add enforcement of 8 characters on this pr. |
|
Perf. Feel free to merge when done |
|
@jackcrane On line 17 of forgotPassword.js , I changed this to the base_url. does this need to be switched back to our production url? |
|
Base_url is an environment variable that is available to the api in prod so you shouldn't need to! |
|
I tested all the edge cases and flow, so everything should now be good to go. I do need to update the css on the user admin page. |
|
I would however double check the flow on ur end and make sure I didnt miss anything. |
jackcrane
left a comment
There was a problem hiding this comment.
Looks great. This is the culmination of a lot of work. You did a great job landing this feature!
|
I tweaked up a few of things on the admin users page, css, url route, and ensured everything works. I pasted a video of me testing the full flow, works pretty well. flow_test.mp4 |
Adding Testcases for Standard login flow, and tweaking a few things up, before this hits production.