Skip to content

Test cases for Non SSO login#146

Open
Muhammudy wants to merge 7 commits intopassword-authfrom
auth-test-cases-ym
Open

Test cases for Non SSO login#146
Muhammudy wants to merge 7 commits intopassword-authfrom
auth-test-cases-ym

Conversation

@Muhammudy
Copy link
Collaborator

@Muhammudy Muhammudy commented Mar 1, 2026

Adding Testcases for Standard login flow, and tweaking a few things up, before this hits production.

@Muhammudy Muhammudy mentioned this pull request Mar 1, 2026
@Muhammudy
Copy link
Collaborator Author

I created a new user for test cases when db spins up. I had to change around a few set items like in _user.test.js hasPassword to be a boolean, this value was set to false, but since I added another user and this has a field its now true. Im not sure how to set it for that specific user.

@Muhammudy Muhammudy requested a review from jackcrane March 1, 2026 03:56
@Muhammudy
Copy link
Collaborator Author

Great, ill make sure the flow isn't broken and add enforcement of 8 characters on this pr.

@jackcrane
Copy link
Collaborator

Perf. Feel free to merge when done

@Muhammudy
Copy link
Collaborator Author

@jackcrane On line 17 of forgotPassword.js , I changed this to the base_url. does this need to be switched back to our production url?

@Muhammudy Muhammudy requested a review from jackcrane March 9, 2026 00:01
@jackcrane
Copy link
Collaborator

Base_url is an environment variable that is available to the api in prod so you shouldn't need to!

@Muhammudy
Copy link
Collaborator Author

I tested all the edge cases and flow, so everything should now be good to go. I do need to update the css on the user admin page.

@Muhammudy
Copy link
Collaborator Author

I would however double check the flow on ur end and make sure I didnt miss anything.

Copy link
Collaborator

@jackcrane jackcrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. This is the culmination of a lot of work. You did a great job landing this feature!

@Muhammudy Muhammudy requested a review from jackcrane March 12, 2026 06:52
@Muhammudy
Copy link
Collaborator Author

I tweaked up a few of things on the admin users page, css, url route, and ensured everything works. I pasted a video of me testing the full flow, works pretty well.

flow_test.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants