Conversation
|
Currently it does look like the server expects each bone and sub-bone to have its own image. This does seem unnecessary; I'll work on a fix to make it so that if the server doesn't find an image for a sub-bone, it will grab the bone image instead. That way, we won't have to do all the manual renaming of sub-bone images when the image just matches the image of the bone. So in the meantime, for any of the images that on the slides are supposed to represent a sub-bone but are really just the image of the parent bone with a colored region annotation overlaid on top, you can only keep the parent bone image. Also, please remake this as a PR into the |
|
Slight correction to my previous comment: it doesn't really matter what the server is doing to grab the subbone images; what determines which boneset/bone/subbone is linked to which image is determined by the "images" field in the description JSON. So to link a subbone to a specific image, you can (as described in the documentation for cleaning the output of |
leandrumartin
left a comment
There was a problem hiding this comment.
The content of all the files looks good. Just make sure when you remake this as a PR into data that the unnecessary files are removed and everything is placed into the correct folders.
- The
Thorax.xml/ppt/folder should not be committed - As with the other PR, when remaking this as a PR into
data, ensure the files are placed into the appropriate existing folders instead of adding new ones
There was a problem hiding this comment.
This file should not be committed
There was a problem hiding this comment.
Should be renamed boneset/thorax.json when placed into data branch
There was a problem hiding this comment.
This file should not be committed
There was a problem hiding this comment.
Unneeded in database, should not be committed
Closes #295
Extracts the data from Thorax.pptx.
Questions:
A lot of the images extracted from the PowerPoint look very similar since the presentation is just four pairs of bones. For the images, would it make sense to keep all the images and rename them? I tried naming them, and it got confusing after a while.
I haven't gotten around to renaming the rest of them. Extra files will be deleted later.
@leandrumartin Let me know if this looks good and I will create a seperate PR.