Node follow-ups #9389
Merged
Node follow-ups #9389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
node-follow-ups
branch
from
d68f049 to
794da4b
Compare
sschuberth
previously approved these changes
Nov 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9389 +/- ##
============================================
- Coverage 66.72% 66.61% -0.11%
Complexity 1234 1234
============================================
Files 247 247
Lines 8962 8885 -77
Branches 974 947 -27
============================================
- Hits 5980 5919 -61
- Misses 2567 2572 +5
+ Partials 415 394 -21
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
The |
Make more clear that all functions could make use of it. Signed-off-by: Frank Viernau <[email protected]>
This is a fix-up for 31592d4. Signed-off-by: Frank Viernau <[email protected]>
This is a fix-up for 743fd64. Signed-off-by: Frank Viernau <[email protected]>
As each package manager has its own dedicated directory, use the root package as the location for common code. Signed-off-by: Frank Viernau <[email protected]>
There is no need to expose this. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
node-follow-ups
branch
from
794da4b to
9c93b99
Compare
sschuberth
approved these changes
Nov 6, 2024
|
Merging despite the unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9261.