npm: Prepare to re-use parsePackage() from outside of Npm
#9323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fviernau
force-pushed
the
yarn-simplifcations
branch
2 times, most recently
from
191e933 to
fb55fa1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9323 +/- ##
=========================================
Coverage 67.45% 67.45%
Complexity 1200 1200
=========================================
Files 241 241
Lines 8498 8500 +2
Branches 904 904
=========================================
+ Hits 5732 5734 +2
Misses 2402 2402
Partials 364 364
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fviernau
force-pushed
the
yarn-simplifcations
branch
from
fb55fa1 to
8409ba2
Compare
fviernau
force-pushed
the
yarn-simplifcations
branch
from
8409ba2 to
b8b7c75
Compare
fviernau
changed the title
parsePackage() from outside of Npm
sschuberth
requested changes
Oct 23, 2024
I've commented on your comments. It'd be great to get some more hint why / in what direction it shall be re-worked. |
fviernau
force-pushed
the
yarn-simplifcations
branch
2 times, most recently
from
e7139a9 to
06f5aa5
Compare
sschuberth
requested changes
Oct 24, 2024
fviernau
force-pushed
the
yarn-simplifcations
branch
from
06f5aa5 to
0744817
Compare
This way `getRemotePackageDetails()` doesn't throw anymore which enables further simplifications. Also the code gets aligned with the code in `Yarn`. Signed-off-by: Frank Viernau <[email protected]>
All implementations of `getRemotePackageDetails()` by now return `null` in case of a failure instead of throwing. Remove `runCatching()`, because it is not needed anymore. Signed-off-by: Frank Viernau <[email protected]>
Prepare for re-using this function from current child classes of `Npm`, once they get refactored to not inherit from `Npm` anymore. Signed-off-by: Frank Viernau <[email protected]>
fviernau
force-pushed
the
yarn-simplifcations
branch
from
0744817 to
33aeb8d
Compare
sschuberth
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all logger dependencies from
parsePackage()to the callers, to avoid the need for passing the logger when moving this function outside ofNpm. And finally perform the move. This prepares for removing the inheritance in node package managers.Part of #9261.