Do not use a sorted map in AdvisorRecord
#7024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only sort on serialization for human readability and reproducibility. Signed-off-by: Frank Viernau <[email protected]>
Make the code using it a bit less verbose. While at it, put each vararg entry provided by the caller on a dedicated line in case of multiple entries. Signed-off-by: Frank Viernau <[email protected]>
Align the name with `advisorRecordOf()` in `AdvisorRecordTest`. Signed-off-by: Frank Viernau <[email protected]>
fviernau
requested review from
a team,
MarcelBochtler and
oheger-bosch
as code owners
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #7024 +/- ##
=========================================
Coverage 64.27% 64.27%
Complexity 1976 1976
=========================================
Files 332 332
Lines 16732 16732
Branches 2382 2382
=========================================
Hits 10754 10754
Misses 4939 4939
Partials 1039 1039
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sschuberth
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits.
Part of #6235 .