-
Notifications
You must be signed in to change notification settings - Fork 332
Add report generation and optimize snippet findings for SCANOSS #10287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add report generation and optimize snippet findings for SCANOSS #10287
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10287 +/- ##
=========================================
Coverage 56.43% 56.43%
Complexity 1604 1604
=========================================
Files 331 331
Lines 12243 12243
Branches 1135 1135
=========================================
Hits 6909 6909
Misses 4887 4887
Partials 447 447
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implement functionality to generate snippet findings reports from SCANOSS scan results. Signed-off-by: Agustin Isasmendi <[email protected]>
Include releaseDate in snippetFindings additionalData and add a new column to display this information in generated reports. Signed-off-by: Agustin Isasmendi <[email protected]>
* Generate one Snippet for each detected line range * Remove duplicate licenses to optimize results * Remove identified snippets from the summary Signed-off-by: Agustin Isasmendi <[email protected]>
c29efef
to
425cc72
Compare
I'd like to comment on this draft already, to avoid going it into an undesired direction eventually: While I agree with @nnobelis saying here that we should not spread conditionals all over the place in reporter templates, I still envision having a single snippet report for any snippet scanner. Instead of having conditionals in the reporter templates, we should introduce variables for any information that can change among snippet scanners, make these available to the reporter, and use them in the template without conditionals. Ideally, such a generic snippet scanner report template should also work for the case when multiple snippet scanners were enabled in a single So my "wish" for an approach would be to:
|
I'm wondering who should work on creating this generic If this makes sense, maybe we could take a iterative approach:
|
I believe that commit 425cc72 If you agree, I'll remove it from the current PR and create a separate one |
Yes, that makes sense to me. We should start with a separate PR that generalizes the existing But I would also like @nnobelis to agree (and help with) this approach. |
Yes, I was about to suggest that any changes to |
Feel free to replace the
I am not sure what you mean by "variables" though. Let's take a concrete example: The FossId report contains a column How would you prevent an ort/plugins/reporters/fossid/src/main/resources/templates/asciidoc/fossid_snippet.ftl Line 84 in f55ce56
|
Ok, that's a different case than what I had in mind. This is not strictly scanner-specific, but you conditionally want to display a generic property depending on whether it's set or not. I also don't see how to avoid conditionals here. What I was referring to is template logic like (pseudo-code ahead)
Instead of that, we should do
in the template, and on the reporter side / host code in ORT ensure that |
This PR implements reporting capabilities for SCANOSS scans:
This builds on top of #10270 implementing SCANOSS SDK migration and filtering capabilities.