test: Add test for CycloneDX XML with authors #10271
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelBochtler
force-pushed
the
invalid-cyclonedx-xml
branch
2 times, most recently
from
f1560eb to
e075508
Compare
fviernau
requested changes
May 6, 2025
| @@ -94,6 +96,30 @@ class CycloneDxReporterFunTest : WordSpec({ | |||
| } | |||
| } | |||
|
|
|||
| "create the expected XML file with authors" { | |||
There was a problem hiding this comment.
I believe instead of adding a new separate test, it would make sense to instead enhance the input of "create the expected XML file". For enhancing it withAuthors() imo is ok. Furthermore, the analog JSON test case IMO should also use / keep on using the same input, so that XML and JSON tests remain analog.
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10271 +/- ##
=========================================
Coverage 56.46% 56.46%
Complexity 1605 1605
=========================================
Files 331 331
Lines 12262 12262
Branches 1141 1141
=========================================
Hits 6924 6924
Misses 4889 4889
Partials 449 449
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This test is currently expected to fail due to a bug in the cyclonedx-core-java [1]. [1]: CycloneDX/cyclonedx-core-java#638 Signed-off-by: Marcel Bochtler <[email protected]>
MarcelBochtler
force-pushed
the
invalid-cyclonedx-xml
branch
from
e075508 to
44103f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test is currently expected to fail due to a bug in the cyclonedx-core-java 1.