Use math.log10 instead of math.log for logarithmic plots#1060
Open
Sukuna0007Abhi wants to merge 1 commit intooss-aspen:devfrom
Open
Use math.log10 instead of math.log for logarithmic plots#1060Sukuna0007Abhi wants to merge 1 commit intooss-aspen:devfrom
Sukuna0007Abhi wants to merge 1 commit intooss-aspen:devfrom
Conversation
- Changed all instances of math.log to math.log10 for base-10 logarithm - Makes logarithmic scale more intuitive (decade-based reasoning) - Implements plotly native log scale with linear axis ticks (1, 10, 100, 1000) - Added log10 values to hover tooltips for educational comparison - Values between 3-4 = thousands, 1-2 = dozens (easier to interpret) This implements both the main request and the 'variation' suggested in the issue for maximum readability and user experience. Fixes oss-aspen#986 Signed-off-by: Sukuna0007Abhi <[email protected]>
cdolfi
requested changes
Jan 19, 2026
Collaborator
cdolfi
left a comment
cdolfi
left a comment
There was a problem hiding this comment.
please only change from log to log 10 in this pr to stay within the scope of the issue
Author
Hi ma'am @cdolfi actually in the issue #986, @giordano suggested "variation" for showing linear tick values. So, that's why I did both math.log to math.log10 and this variation... The graph axes show real values (10, 100, 1000, etc.) using Plotly's log_x and log_y & If you think this is not needed then I will revert it pls review one time more.. |
MoralCode
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #986
What I changed
Changed math.log (natural log, base e) to math.log10 (base 10) in the project velocity visualization. Also made the axes show actual values like 1, 10, 100, 1000 instead of log values.
Why
As @giordano mentioned in the issue, base-10 logarithms are way easier to understand. When you see a value between 3 and 4, you immediately know "that's thousands of commits" rather than having to calculate powers of e in your head.
What changed
@cdolfi Thanks for tagging me on this one!
Pls review @cdolfi @MoralCode