Skip to content

Refactor index_layout: Extract nested components into modular utility functions #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdolfi merged 1 commit into from
Dec 4, 2025
Merged

Refactor index_layout: Extract nested components into modular utility functions #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions 8Knot/assets/color.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,17 @@
--gray-light: #787878;
--gray-lighter: #E5E5E5;
--border-divider: #909090;

/* Component-specific colors */
--placeholder-bg-color: #1D1D1D;
--placeholder-text-color: #9c9c9c;
--button-light-bg: #f8f9fa;
--button-text-light: #fff9f9;

/* MultiSelect pill colors */
--pill-default-bg: #555555;
--pill-default-color: #ffffff;

/* Table colors */
--table-bg-dark: #222;
--table-row-hover: #2e2e2e;
Expand Down
97 changes: 97 additions & 0 deletions 8Knot/assets/main_layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@
--placeholder-font-size: 16px;
--placeholder-line-height: 20px;
--placeholder-top-offset: 1px;
/* MultiSelect specific sizing */
--multiselect-min-height: 48px;
--multiselect-padding: 12px 16px 12px 44px;
--multiselect-item-margin: 2px 4px;
}


Expand Down Expand Up @@ -392,6 +396,99 @@ a.sidebar-section-text {
}


/* ==== UTILITY COMPONENT CLASSES ==== */


/* Generic transparent icon button */

button.icon-button.btn,
.btn.icon-button {
background-color: transparent;
border: none;
padding: var(--spacing-xs) var(--spacing-sm);
font-size: 14px;
box-shadow: none;
}

button.icon-button.btn:hover,
button.icon-button.btn:focus,
button.icon-button.btn:active,
.btn.icon-button:hover,
.btn.icon-button:focus,
.btn.icon-button:active {
background-color: transparent;
border: none;
box-shadow: none;
color: inherit;
}


/* Login disabled banner positioning */

.login-banner-container {
position: fixed;
top: 70px;
right: 20px;
z-index: 1000;
}

.login-banner-alert {
background-color: var(--baby-blue-100);
border-color: var(--baby-blue-700);
border: 1px solid var(--baby-blue-700);
border-left: 5px solid var(--baby-blue-700);
box-shadow: 0 2px 8px var(--shadow-color-md);
max-width: 400px;
padding: 15px;
z-index: 1000;
}
Comment on lines +435 to +444
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Fix CSS shorthand property override.

The border shorthand on line 414 overrides the border-color set on line 413, making the border-color declaration ineffective. This was flagged by static analysis.

 .login-banner-alert {
     background-color: var(--baby-blue-100);
-    border-color: var(--baby-blue-700);
     border: 1px solid var(--baby-blue-700);
     border-left: 5px solid var(--baby-blue-700);
     box-shadow: 0 2px 8px var(--shadow-color-md);
     max-width: 400px;
     padding: 15px;
     z-index: 1000;
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.login-banner-alert {
background-color: var(--baby-blue-100);
border-color: var(--baby-blue-700);
border: 1px solid var(--baby-blue-700);
border-left: 5px solid var(--baby-blue-700);
box-shadow: 0 2px 8px var(--shadow-color-md);
max-width: 400px;
padding: 15px;
z-index: 1000;
}
.login-banner-alert {
background-color: var(--baby-blue-100);
border: 1px solid var(--baby-blue-700);
border-left: 5px solid var(--baby-blue-700);
box-shadow: 0 2px 8px var(--shadow-color-md);
max-width: 400px;
padding: 15px;
z-index: 1000;
}
🧰 Tools
🪛 Biome (2.1.2)

[error] 414-414: Unexpected shorthand property border after border-color

(lint/suspicious/noShorthandPropertyOverrides)

🤖 Prompt for AI Agents 
In 8Knot/assets/main_layout.css around lines 411 to 420, the `border: 1px solid
var(--baby-blue-700)` shorthand on line 414 overrides the earlier `border-color`
on line 413; remove the conflicting shorthand or replace it with explicit
properties (e.g., set `border-width: 1px; border-style: solid;` and keep
`border-color: var(--baby-blue-700);`) or move the `border-color` declaration
after the shorthand so the intended color is preserved.


.login-banner-heading {
color: var(--color-black);
font-weight: 600;
margin: 0 0 8px 0;
text-shadow: none;
}

.login-banner-text {
color: #333333;
margin: 0 0 10px 0;
}

.login-banner-link {
font-weight: 500;
color: #1565C0;
}


/* Search component specific classes */

.search-input-wrapper {
position: relative;
}

.search-input-section {
width: 100%;
margin-bottom: var(--spacing-md);
padding: 0 6px;
}

.search-controls-stack {
width: 100%;
justify-content: center;
margin-top: var(--spacing-md);
}

.search-bar-wrapper {
padding-top: var(--spacing-md);
}

.repo-list-alert {
overflow-y: scroll;
max-height: 440px;
}


/* Utility Classes */

.hidden {
Expand Down
Loading
Loading