Skip to content

Depreciations #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 24, 2025
Merged

Depreciations #4

merged 4 commits into from
Feb 24, 2025

Conversation

MrDevopsman
Copy link
Contributor

see commit log and files for changes/reasons

│ Warning: Redundant ignore_changes element
│
│   on .terraform/modules/security_header_lambda/aws_lambda_function.tf line 2, in resource "aws_lambda_function" "lambda":
│    2: resource "aws_lambda_function" "lambda" {
│
│ Adding an attribute name to ignore_changes tells Terraform to ignore future changes to the argument in configuration after the
│ object has been created, retaining the value originally configured.
│
│ The attribute last_modified is decided by the provider alone and therefore there can be no configured value to compare with.
│ Including this attribute in ignore_changes has no effect. Remove the attribute from ignore_changes to quiet this warning.
╵
╷
│ Warning: Deprecated Resource
│
│   with module.security_header_lambda.aws_s3_bucket_object.artifact,
│   on .terraform/modules/security_header_lambda/aws_s3_bucket_object_artifact_upload.tf line 5, in resource "aws_s3_bucket_object" "artifact":
│    5: resource "aws_s3_bucket_object" "artifact" {
│
│ use the aws_s3_object resource instead
│
│ (and one more similar warning elsewhere)
╵
╷
│ Warning: Argument is deprecated
│
│   with module.security_header_lambda.aws_s3_bucket_object.artifact,
│   on .terraform/modules/security_header_lambda/aws_s3_bucket_object_artifact_upload.tf line 7, in resource "aws_s3_bucket_object" "artifact":
│    7:   bucket                 = data.aws_s3_bucket.artifact_bucket.id
│
│ Use the aws_s3_object resource instead
│
│ (and one more similar warning elsewhere)
Copy link
Contributor

@andysingleton andysingleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MrDevopsman MrDevopsman merged commit bfa4b87 into main Feb 24, 2025
1 check passed
@MrDevopsman MrDevopsman deleted the depreciations branch February 24, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants