Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased coverage for integration dns tests #221

Merged
merged 1 commit into from
Feb 22, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion integration_test/dns/lookup/lookup_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ void main() {

await tester.pumpAndSettle(const Duration(seconds: 2));

expect(find.byType(AdaptiveListTile), findsAny);
final pingWidget = find.byKey(WidgetKey.dnsResultTile.key).first;
await tester.tap(pingWidget);

await tester.pumpAndSettle();

expect(find.byType(Scaffold), findsOneWidget);
});
});
}
75 changes: 74 additions & 1 deletion integration_test/dns/reverse_lookup/reverse_lookup.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,80 @@ void main() {

await tester.pumpAndSettle(const Duration(seconds: 2));

expect(find.text("maa03s29-in-f14.1e100.net"), findsOne);
final textWidget = find.text("maa03s29-in-f14.1e100.net");

expect(textWidget, findsOneWidget);
await tester.tap(textWidget);
await tester.pumpAndSettle();
});

testWidgets('tap on the reverse DNS lookup button, verify error returned',
(tester) async {
// Load app widget.
await tester.pumpWidget(const MyApp(true));
await tester.pumpAndSettle();

// Verify that there are 4 widgets at homepage
expect(find.bySubtype<AdaptiveListTile>(), findsAtLeastNWidgets(4));

// Finds the scan for devices button to tap on.
final reverseDnsLookupButton =
find.byKey(WidgetKey.reverseDnsLookupButton.key);

// Emulate a tap on the button.
await tester.tap(reverseDnsLookupButton);
await tester.pumpAndSettle();

expect(
find.text(StringValue.reverseDnsLookupEmptyPlaceholder),
findsOneWidget,
);

await tester.enterText(
find.byType(TextFormField),
'172.217.160.',
);
await tester.pumpAndSettle();

final submitButton = find.byKey(WidgetKey.basePageSubmitButton.key);
await tester.tap(submitButton);
expect(find.byType(Scaffold), findsOneWidget);
await tester.pumpAndSettle();
});

testWidgets(
'tap on the reverse DNS lookup button, verify reverse address not found returned',
(tester) async {
// Load app widget.
await tester.pumpWidget(const MyApp(true));
await tester.pumpAndSettle();

// Verify that there are 4 widgets at homepage
expect(find.bySubtype<AdaptiveListTile>(), findsAtLeastNWidgets(4));

// Finds the scan for devices button to tap on.
final reverseDnsLookupButton =
find.byKey(WidgetKey.reverseDnsLookupButton.key);

// Emulate a tap on the button.
await tester.tap(reverseDnsLookupButton);
await tester.pumpAndSettle();

expect(
find.text(StringValue.reverseDnsLookupEmptyPlaceholder),
findsOneWidget,
);

await tester.enterText(
find.byType(TextFormField),
'0.0.0.0',
);
await tester.pumpAndSettle();

final submitButton = find.byKey(WidgetKey.basePageSubmitButton.key);
await tester.tap(submitButton);
expect(find.byType(Scaffold), findsOneWidget);
await tester.pumpAndSettle();
});
});
}
2 changes: 2 additions & 0 deletions lib/pages/dns/dns_page.dart
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import 'package:flutter/material.dart';
import 'package:flutter/services.dart';
import 'package:vernet/pages/base_page.dart';
import 'package:vernet/ui/adaptive/adaptive_list.dart';
import 'package:vernet/values/keys.dart';
import 'package:vernet/values/strings.dart';

class DNSPage extends StatefulWidget {
Expand All @@ -29,6 +30,7 @@ class _DNSPageState extends BasePage<DNSPage> {
itemCount: _addresses.length,
itemBuilder: (context, index) {
return AdaptiveListTile(
key: WidgetKey.dnsResultTile.key,
onTap: () {
Clipboard.setData(
ClipboardData(text: _addresses[index].address),
Expand Down
1 change: 1 addition & 0 deletions lib/values/keys.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ enum WidgetKey implements Comparable<WidgetKey> {
lightThemeRadioButton('lightThemeRadioButton'),
systemThemeRadioButton('systemThemeRadioButton'),
shortPortChip('shortPortChip'),
dnsResultTile('dnsResultTile'),
fullPortChip('fullPortChip'),
youtubeChip('youtubeChip'),
localIpChip('localIpChip'),
Expand Down
Loading