Skip to content

Conversation

@Marc-marc-marc
Copy link
Contributor

close #2675

@Famlam
Copy link
Collaborator

Famlam commented Jan 5, 2026

Would you mind writing the comments in English 😇 ?

@frodrigo
Copy link
Contributor

frodrigo commented Jan 5, 2026

Does this fix really work ? As quoted CSV "," could make the count done this way invalid.

@Marc-marc-marc
Copy link
Contributor Author

Would you mind writing the comments in English 😇 ?

done (and squash 3 commits into 1)

@Marc-marc-marc
Copy link
Contributor Author

Marc-marc-marc commented Jan 6, 2026

Does this fix really work ? As quoted CSV "," could make the count done this way invalid.

yes

 ./osmose_run.py --country france_local_db  --analyser=analyser_merge_post_box_FR --skip-upload | tee /tmp/marc.log
/usr/lib/python3/dist-packages/requests/__init__.py:87: RequestsDependencyWarning: urllib3 (2.0.3) or chardet (4.0.0) doesn't match a supported version!
  warnings.warn("urllib3 ({}) or chardet ({}) doesn't match a supported "
2026-01-06 09:28:10 osmose backend version: v1.2-2022-10-09-990-g0b510a3c
2026-01-06 09:28:10 loading analyses 
2026-01-06 09:28:10   load merge_post_box_FR
2026-01-06 09:28:12   check database
2026-01-06 09:28:12 import post scripts
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    DO
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE FUNCTION
2026-01-06 09:28:12    CREATE TABLE
2026-01-06 09:28:12   OSM data timestamp: 2026-01-06 09:18:29
2026-01-06 09:28:12 france_local_db : merge_post_box_FR
2026-01-06 09:28:13   run osmosis all analyser Analyser_Merge_Post_box_FR
2026-01-06 09:28:13   Analyser_Merge.py:1286 sql
2026-01-06 09:28:14   Analyser_Merge.py:871 sql
2026-01-06 09:28:14   Analyser_Merge.py:883 sql
2026-01-06 09:28:14   Load raw data into database
2026-01-06 09:28:14   Analyser_Merge.py:901 sql
2026-01-06 09:28:14   Analyser_Merge.py:906 sql
2026-01-06 09:28:14   Convert raw data to tags
2026-01-06 09:28:14   Analyser_Merge.py:912 sql
2026-01-06 09:28:14   Analyser_Merge.py:913 sql
2026-01-06 09:28:14   Analyser_Merge.py:946 sql
2026-01-06 09:28:58   Analyser_Merge.py:947 sql
2026-01-06 09:29:00   Analyser_Merge.py:956 sql
2026-01-06 09:29:00   Analyser_Merge.py:957 sql
2026-01-06 09:29:01   Analyser_Merge.py:961 sql
2026-01-06 09:29:01   Analyser_Merge.py:963 sql
2026-01-06 09:29:01   Analyser_Merge.py:965 sql
2026-01-06 09:29:01   Analyser_Merge.py:966 sql
2026-01-06 09:29:01   Analyser_Merge.py:967 sql
2026-01-06 09:29:01   Retrieve OSM item
2026-01-06 09:29:01   Analyser_Merge.py:1303 sql
2026-01-06 09:30:01   Analyser_Merge.py:1449 sql
2026-01-06 09:30:01   Analyser_Merge.py:1450 sql
2026-01-06 09:30:01   Analyser_Merge.py:1467 sql
2026-01-06 09:30:02   Analyser_Merge.py:1468 sql
2026-01-06 09:30:03   Analyser_Merge.py:1485 xml generation
2026-01-06 09:30:34   Analyser_Merge.py:1491 sql
2026-01-06 09:30:34   Analyser_Merge.py:1492 sql
2026-01-06 09:30:34   Analyser_Merge.py:1508 xml generation
2026-01-06 09:30:50   Analyser_Merge.py:1521 sql
2026-01-06 09:30:51   Analyser_Merge.py:1522 sql
2026-01-06 09:30:51   Analyser_Merge.py:1537 xml generation
2026-01-06 09:31:02   Analyser_Merge.py:1543 sql
2026-01-06 09:31:16 cleaning : 
2026-01-06 09:31:16   Schema size is: 280880939008 bytes (261.59 GiB)
2026-01-06 09:31:16 end of analyses

Would you like the code to handle commas other than CSV separators (e.g. in address cells) with csv.reader, or could this be done on another PR if it ever happens?

@frodrigo frodrigo merged commit 434f429 into osmose-qa:dev Jan 6, 2026
3 checks passed
@Marc-marc-marc Marc-marc-marc deleted the patch-1 branch January 6, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

merge_post_box_FR crash in case of empty ending cells

3 participants