Skip to content

fix defibrillators FR analyser #2657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
trouyer wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

fix defibrillators FR analyser #2657

trouyer wants to merge 4 commits into from
+6 −6

Conversation

@trouyer
Copy link
Contributor

@trouyer trouyer commented Dec 21, 2025 •
edited
Loading

Hi,

this PR fix issue #2613

Source data https://www.data.gouv.fr/datasets/geodae-base-nationale-des-defibrillateurs have openning days and hours in arrays, without curly braces. eg, for 24/7:

"c_disp_j": [
    "7j/7"
],
"c_disp_h": [
    "24h/24"
]

coordinates are not geom_x and geom_y but c_long_coor1 and c_lat_coor1 (cf #2268)

@trouyer trouyer mentioned this pull request Dec 21, 2025
Open
@trouyer trouyer force-pushed the fix/defibrillators_opening_hour branch from 6643acb to 6a569b6 Compare December 21, 2025 12:05
@trouyer trouyer mentioned this pull request Dec 21, 2025
Open
@trouyer trouyer changed the title fix normalizedHours for defibrillators FR analyser fix defibrillators FR analyser Dec 21, 2025
@trouyer trouyer marked this pull request as draft December 21, 2025 13:58
@frodrigo
Copy link
Contributor

frodrigo commented Jan 3, 2026

You can rebase the branch to fix the tests

@trouyer trouyer force-pushed the fix/defibrillators_opening_hour branch from 6a569b6 to af88f2b Compare January 3, 2026 20:21
@frodrigo
Copy link
Contributor

frodrigo commented Jan 3, 2026

Still a draf PR ?

@trouyer trouyer marked this pull request as ready for review January 4, 2026 09:41
@trouyer trouyer force-pushed the fix/defibrillators_opening_hour branch from af88f2b to 4487c63 Compare January 4, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trouyer @frodrigo @weblate