enrich irve socket max output

[tykayn]

removes values that are more than the max known of 400kW to be set as the max power output of a charging station, adds a tag to correct values.
Also handles enumerations of this values to keep the maximum value.

The column evaluated in the dataset of French IRVE is "puissance_nominale" by the function "getPuissanceNominaleInKw".

Tested locally with docker on Monaco and Ile de France zones, returns proposals for the "charging_station:output" tag as "n kW" when finding good values.

[frodrigo]

Please, can you rework your PR in order to minimize code changes. Include only english comment to code.

[tykayn]

@frodrigo i updated the branch to minimize changes and translated comments in English

[frodrigo]

raw is not alredy a string ?

[tykayn]

now that you say it, it must be so. i changed it

[frodrigo]

It s class attrib, will be defined.

[tykayn]

ok changed to a call of self

[frodrigo]

@tykayn please, can you review the comments.

[frodrigo]

Thank you. Merged, but not deployed yet.

[Marc-marc-marc]

I didn't understand how this could work, the pre-processed csv doesn't have puissance_nominalefield
maybe also take a look at Jungle-Bus/ref-EU-EVSE#15

[Marc-marc-marc]

I also doubt that charging_station:output can be deduced from opendta in France :
opendata seems to give the nominal power per socket
charging_station:output gives the total power of the station.

Examples :

• a station with 2 type2 22 kW : charging_station:output is somewhere between 22 and 44 kW
• a station with 4 combo_ccs 400 kW : charging_station:output somewhere between 400 and 1600 kW.
• a station Tesla V2 with 8 man_made=charge_point each with 2 socket:type2_combo:output=150 kW have a charging_station:output between 150 kW and 8x150 kW (and never 16x 150 kW due to power sharing between 2 sockets on the same dispenser (borne)
  puissance_nominale can only be used to set the "best" socket:*:output as @guiohm is trying todo with the PR listed above

[tykayn]

hi @Marc-marc-marc
it is true, the field seem to be missing in the pre-processed.csv, we should add it.

in the original open data it apprears to be associated to maybe one or more sockets, so it is per stall. But open data providers seem to disagree about wether a line in the spreadsheet is a stall or a pool of stalls.
in the wiki i noticed that charging_station:output is giving the max kW of a stall, but if it is not used to give this info we have a problem and maybe we need some cleanup or an other tag to clearly state that the number is a sum of the charge points, something like "charging_station:output:sum", because knowing the max kW of a stall is very useful, where knowing the sum of a pool is not useful at all for most consumers who want to know if their vehicle will charge at a reasonable speed at one stall.

it didnt make crash my dev env when i ran the analysis, so that is weird.

the PR of @guiohm is interesting, i hope it will bring some clarity.

[frodrigo]

it didnt make crash my dev env when i ran the analysis, so that is weird.

Note, there is download cache.