Merge pull request #2253 from joto/more-const-ref

Use const ref params in properties code
osm2pgsql-dev · Sep 18, 2024 · 9b283f6 · 9b283f6
2 parents 55d1592 + c42e0f6
commit 9b283f6
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/properties.cpp b/src/properties.cpp
@@ -90,14 +90,14 @@ void properties_t::set_string(std::string const &property,
     m_to_update[property] = value;
 }
 
-void properties_t::set_int(std::string property, int64_t value)
+void properties_t::set_int(std::string const &property, int64_t value)
 {
-    set_string(std::move(property), std::to_string(value));
+    set_string(property, std::to_string(value));
 }
 
-void properties_t::set_bool(std::string property, bool value)
+void properties_t::set_bool(std::string const &property, bool value)
 {
-    set_string(std::move(property), value ? "true" : "false");
+    set_string(property, value ? "true" : "false");
 }
 
 void properties_t::init_table()

diff --git a/src/properties.hpp b/src/properties.hpp
@@ -63,7 +63,7 @@ class properties_t
      * \param property Name of the property
      * \param value Value of the property
      */
-    void set_int(std::string property, int64_t value);
+    void set_int(std::string const &property, int64_t value);
 
     /**
      * Set property to boolean value. In the database this will show up as the
@@ -72,7 +72,7 @@ class properties_t
      * \param property Name of the property
      * \param value Value of the property
      */
-    void set_bool(std::string property, bool value);
+    void set_bool(std::string const &property, bool value);
 
     /**
      * Initialize the database table 'osm2pgsql_properties'. It is created if